From 470a5f8b56380a225f35b1ede9a9698e10400df0 Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Thu, 29 Aug 2024 17:15:51 -0400 Subject: [PATCH 1/3] [CI] After a `fix:*` command, tell user to rerun full checks (#5122) --- .github/workflows/pr-actions.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-actions.yml b/.github/workflows/pr-actions.yml index 28fdb9a22071..42af5006bc93 100644 --- a/.github/workflows/pr-actions.yml +++ b/.github/workflows/pr-actions.yml @@ -101,9 +101,16 @@ jobs: env: GH_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} + - name: Report success and ask to run full checks + if: ${{ !failure() && !cancelled() }} + run: | + gh pr comment $PR_NUM -b "fix:${PR_ACTION} was [successful]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID).\n### NOW RUN `/fix:all` to ensure that there are no other check issues." + env: + GH_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} + - name: Report an error in the case of failure if: ${{ failure() || cancelled() }} run: | - gh pr comment $PR_NUM -b "fix:${PR_ACTION} run failed, please check $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID for details" + gh pr comment $PR_NUM -b "fix:${PR_ACTION} failed or was cancelled. For details, see $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID." env: GH_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} From 8614c7b6c47e9a5ae29cb08a643b8b04e6c064d9 Mon Sep 17 00:00:00 2001 From: Patrice Chalin Date: Fri, 30 Aug 2024 05:42:58 -0400 Subject: [PATCH 2/3] [CI] PR-actions: escape PR comment special char (#5126) --- .github/workflows/pr-actions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-actions.yml b/.github/workflows/pr-actions.yml index 42af5006bc93..ba9a293e5724 100644 --- a/.github/workflows/pr-actions.yml +++ b/.github/workflows/pr-actions.yml @@ -104,7 +104,7 @@ jobs: - name: Report success and ask to run full checks if: ${{ !failure() && !cancelled() }} run: | - gh pr comment $PR_NUM -b "fix:${PR_ACTION} was [successful]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID).\n### NOW RUN `/fix:all` to ensure that there are no other check issues." + gh pr comment $PR_NUM -b "fix:${PR_ACTION} was [successful]($GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID).\\n### NOW (RE-)RUN \`/fix:all\` to ensure that there are no other check issues." env: GH_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} From 1c6697de9c4d67fb72231354d5d9c6cdcfdfa64b Mon Sep 17 00:00:00 2001 From: Cijo Thomas Date: Fri, 30 Aug 2024 02:44:58 -0700 Subject: [PATCH 3/3] Mention sync gauge in Otel Go metrics docs (#5116) --- content/en/docs/languages/go/instrumentation.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/en/docs/languages/go/instrumentation.md b/content/en/docs/languages/go/instrumentation.md index 41ca2e98046f..15987be1fc29 100644 --- a/content/en/docs/languages/go/instrumentation.md +++ b/content/en/docs/languages/go/instrumentation.md @@ -301,6 +301,8 @@ OpenTelemetry Go currently supports the following instruments: increments - Histogram, a synchronous instrument that supports arbitrary values that are statistically meaningful, such as histograms, summaries, or percentile +- Synchronous Gauge, a synchronous instrument that supports non-additive values, + such as room temperature. - Asynchronous Gauge, an asynchronous instrument that supports non-additive values, such as room temperature - UpDownCounter, a synchronous instrument that supports increments and