From 205f6209b3e398b2141b3b54cf008f848fc0599d Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Tue, 8 Feb 2022 09:31:23 -0800 Subject: [PATCH 1/5] Clarify what does wildcard mean in the Metrics SDK View --- specification/metrics/sdk.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 1122b3df6f0..bfb1ecaa9a8 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -147,7 +147,12 @@ are the inputs: * The Instrument selection criteria (required), which covers: * The `type` of the Instrument(s) (optional). - * The `name` of the Instrument(s), with wildcard support (optional). + * The `name` of the Instrument(s). [OpenTelemetry SDK](../overview.md#sdk) + authors MAY choose to support `name` that contains wildcards, with the + question mark (`?`) matching exactly one character and the asterisk + character (`*`) matching zero or more characters. In addition, the + OpenTelemetry SDK authors MAY choose to support additional predicates that + are idiomatic for their language (e.g. regular expressions, callbacks). * The `name` of the Meter (optional). * The `version` of the Meter (optional). * The `schema_url` of the Meter (optional). From 948719e0b20671a42b71e92b712cf2c58a84db2d Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Tue, 8 Feb 2022 09:34:59 -0800 Subject: [PATCH 2/5] changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 821833cb3ba..0f170cc3ae7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -41,6 +41,8 @@ release. [#2032](https://github.com/open-telemetry/opentelemetry-specification/pull/2061) - Changed default Prometheus Exporter host from `0.0.0.0` to `localhost`. ([#2282](https://github.com/open-telemetry/opentelemetry-specification/pull/2282)) +- Clarified wildcard and predicate support in metrics SDK View API. + ([#2325])(https://github.com/open-telemetry/opentelemetry-specification/pull/2325)) ### Logs From 15c805fc16ae96cf03c50ea170c9439c056097f8 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Tue, 8 Feb 2022 10:50:38 -0800 Subject: [PATCH 3/5] Update specification/metrics/sdk.md Co-authored-by: Diego Hurtado --- specification/metrics/sdk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index bfb1ecaa9a8..55ca044cd43 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -148,7 +148,7 @@ are the inputs: * The Instrument selection criteria (required), which covers: * The `type` of the Instrument(s) (optional). * The `name` of the Instrument(s). [OpenTelemetry SDK](../overview.md#sdk) - authors MAY choose to support `name` that contains wildcards, with the + authors MAY choose to support wildcard characters, with the question mark (`?`) matching exactly one character and the asterisk character (`*`) matching zero or more characters. In addition, the OpenTelemetry SDK authors MAY choose to support additional predicates that From 2c416dc0f0980a6649cdcefa46b8b322ee8bab44 Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Tue, 8 Feb 2022 10:52:57 -0800 Subject: [PATCH 4/5] feedback --- specification/metrics/sdk.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index 55ca044cd43..f3db3addde9 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -150,9 +150,7 @@ are the inputs: * The `name` of the Instrument(s). [OpenTelemetry SDK](../overview.md#sdk) authors MAY choose to support wildcard characters, with the question mark (`?`) matching exactly one character and the asterisk - character (`*`) matching zero or more characters. In addition, the - OpenTelemetry SDK authors MAY choose to support additional predicates that - are idiomatic for their language (e.g. regular expressions, callbacks). + character (`*`) matching zero or more characters. * The `name` of the Meter (optional). * The `version` of the Meter (optional). * The `schema_url` of the Meter (optional). From ecdd3a44392335e2534479586fa242835081bbae Mon Sep 17 00:00:00 2001 From: Reiley Yang Date: Tue, 8 Feb 2022 12:14:01 -0800 Subject: [PATCH 5/5] fix url --- CHANGELOG.md | 2 +- specification/metrics/sdk.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f170cc3ae7..7b83f24d227 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,7 +42,7 @@ release. - Changed default Prometheus Exporter host from `0.0.0.0` to `localhost`. ([#2282](https://github.com/open-telemetry/opentelemetry-specification/pull/2282)) - Clarified wildcard and predicate support in metrics SDK View API. - ([#2325])(https://github.com/open-telemetry/opentelemetry-specification/pull/2325)) + ([#2325](https://github.com/open-telemetry/opentelemetry-specification/pull/2325)) ### Logs diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md index f3db3addde9..07c93a42023 100644 --- a/specification/metrics/sdk.md +++ b/specification/metrics/sdk.md @@ -148,9 +148,9 @@ are the inputs: * The Instrument selection criteria (required), which covers: * The `type` of the Instrument(s) (optional). * The `name` of the Instrument(s). [OpenTelemetry SDK](../overview.md#sdk) - authors MAY choose to support wildcard characters, with the - question mark (`?`) matching exactly one character and the asterisk - character (`*`) matching zero or more characters. + authors MAY choose to support wildcard characters, with the question mark + (`?`) matching exactly one character and the asterisk character (`*`) + matching zero or more characters. * The `name` of the Meter (optional). * The `version` of the Meter (optional). * The `schema_url` of the Meter (optional).