From 5ca172efcbcab787c4278f4e8b8d7503bcbbd7e6 Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Tue, 21 Dec 2021 19:36:15 -0800 Subject: [PATCH 1/3] Upgrade semconv generator to v0.8.0 --- .vscode/settings.json | 2 +- semantic_conventions/README.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 204dc438d8d..1a9c1838421 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -10,7 +10,7 @@ "MD040": false, }, "yaml.schemas": { - "https://raw.githubusercontent.com/open-telemetry/build-tools/v0.7.0/semantic-conventions/semconv.schema.json": [ + "https://raw.githubusercontent.com/open-telemetry/build-tools/v0.8.0/semantic-conventions/semconv.schema.json": [ "semantic_conventions/**/*.yaml" ] }, diff --git a/semantic_conventions/README.md b/semantic_conventions/README.md index 64e4e821945..9eb8e978fd5 100644 --- a/semantic_conventions/README.md +++ b/semantic_conventions/README.md @@ -17,12 +17,12 @@ i.e.: Semantic conventions for the spec MUST adhere to the [attribute naming conventions](../specification/common/attribute-naming.md). -Refer to the [syntax](https://github.com/open-telemetry/build-tools/tree/v0.7.0/semantic-conventions/syntax.md) +Refer to the [syntax](https://github.com/open-telemetry/build-tools/tree/v0.8.0/semantic-conventions/syntax.md) for how to write the YAML files for semantic conventions and what the YAML properties mean. A schema file for VS code is configured in the `/.vscode/settings.json` of this repository, enabling auto-completion and additional checks. Refer to -[the generator README](https://github.com/open-telemetry/build-tools/tree/v0.7.0/semantic-conventions/README.md) for what extension you need. +[the generator README](https://github.com/open-telemetry/build-tools/tree/v0.8.0/semantic-conventions/README.md) for what extension you need. ## Generating markdown @@ -33,7 +33,7 @@ formatted Markdown tables for all semantic conventions in the specification. Run make table-generation ``` -For more information, see the [semantic convention generator](https://github.com/open-telemetry/build-tools/tree/v0.7.0/semantic-conventions) +For more information, see the [semantic convention generator](https://github.com/open-telemetry/build-tools/tree/v0.8.0/semantic-conventions) in the OpenTelemetry build tools repository. Using this build tool, it is also possible to generate code for use in OpenTelemetry language projects. From 495a44eabfe47ebb72c15a5deebca226a40a9582 Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Tue, 21 Dec 2021 19:51:13 -0800 Subject: [PATCH 2/3] update specs with semconv gen 0.8.0 --- specification/trace/semantic_conventions/exceptions.md | 2 ++ specification/trace/semantic_conventions/http.md | 2 +- specification/trace/semantic_conventions/rpc.md | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/specification/trace/semantic_conventions/exceptions.md b/specification/trace/semantic_conventions/exceptions.md index d71cc6209e7..81f92075dd0 100644 --- a/specification/trace/semantic_conventions/exceptions.md +++ b/specification/trace/semantic_conventions/exceptions.md @@ -42,6 +42,8 @@ The table below indicates which attributes should be added to the `Event` and their types. +The event name MUST be `exception`. + | Attribute | Type | Description | Examples | Required | |---|---|---|---|---| | `exception.type` | string | The type of the exception (its fully-qualified class name, if applicable). The dynamic type of the exception should be preferred over the static type in languages that support it. | `java.net.ConnectException`; `OSError` | See below | diff --git a/specification/trace/semantic_conventions/http.md b/specification/trace/semantic_conventions/http.md index 04783e9110b..706564f680e 100644 --- a/specification/trace/semantic_conventions/http.md +++ b/specification/trace/semantic_conventions/http.md @@ -90,7 +90,7 @@ Don't set the span status description if the reason can be inferred from `http.s | `SPDY` | SPDY protocol. | | `QUIC` | QUIC protocol. | -Following attributes MUST be provided **at span creation time** (when provided at all): +Following attributes MUST be provided **at span creation time** (when provided at all), so they can be considered for sampling decisions: * `http.method` * `http.url` diff --git a/specification/trace/semantic_conventions/rpc.md b/specification/trace/semantic_conventions/rpc.md index 92edb4fabaf..362e8a37c54 100644 --- a/specification/trace/semantic_conventions/rpc.md +++ b/specification/trace/semantic_conventions/rpc.md @@ -103,6 +103,8 @@ and one received message will be recorded for both client and server spans. The event name MUST be `"message"`. +The event name MUST be `message`. + | Attribute | Type | Description | Examples | Required | |---|---|---|---|---| | `message.type` | string | Whether this is a received or sent message. | `SENT` | No | From a7b7b345791f523924983ae2aadde1b4b9e16b9a Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Wed, 22 Dec 2021 13:05:06 -0800 Subject: [PATCH 3/3] makefile --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a7e04fb8b58..c87279759e6 100644 --- a/Makefile +++ b/Makefile @@ -11,7 +11,7 @@ MARKDOWN_TOC=./node_modules/.bin/markdown-toc # see https://github.com/open-telemetry/build-tools/releases for semconvgen updates # Keep links in semantic_conventions/README.md and .vscode/settings.json in sync! -SEMCONVGEN_VERSION=0.7.0 +SEMCONVGEN_VERSION=0.8.0 $(MISSPELL): cd $(TOOLS_DIR) && go build -o $(MISSPELL_BINARY) github.com/client9/misspell/cmd/misspell