From 17959b998c4a02c6f25bd01a87b48ddbe5bf77a4 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Thu, 16 Dec 2021 01:15:00 -0600 Subject: [PATCH 1/2] Define an instrumentation library name for the OT Shim. --- specification/compatibility/opentracing.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/specification/compatibility/opentracing.md b/specification/compatibility/opentracing.md index 25a0bbba592..1a1ff583403 100644 --- a/specification/compatibility/opentracing.md +++ b/specification/compatibility/opentracing.md @@ -59,7 +59,9 @@ This operation is used to create a new OpenTracing `Tracer`: This operation MUST accept the following parameters: -- An OpenTelemetry `Tracer`, used to create `Span`s. +- An OpenTelemetry `TracerProvider`, used to get a `Tracer` with + instrumentation name and version set to `opentracing-shim` + and the shim version respectively. - OpenTelemetry `Propagator`s to be used to perform injection and extraction for the the OpenTracing `TextMap` and `HTTPHeaders` formats. If not specified, no `Propagator` values will be stored in the Shim, and @@ -70,12 +72,12 @@ The API MUST return an OpenTracing `Tracer`. ```java // Create a Tracer Shim relying on the global propagators. -createTracerShim(tracer); +createTracerShim(tracerProvider); // Create a Tracer Shim using: // 1) TraceContext propagator for TextMap // 2) Jaeger propagator for HttPHeaders. -createTracerShim(tracer, OTPropagatorsBuilder() +createTracerShim(tracerProvider, OTPropagatorsBuilder() .setTextMap(W3CTraceContextPropagator.getInstance()) .setHttpHeaders(JaegerPropagator.getInstance()) .build()); From 48f95fae4098eceade657b0c565cbf228f0a8e00 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Thu, 16 Dec 2021 17:35:09 -0600 Subject: [PATCH 2/2] Apply feedback. --- specification/compatibility/opentracing.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specification/compatibility/opentracing.md b/specification/compatibility/opentracing.md index 1a1ff583403..80616e1ec9f 100644 --- a/specification/compatibility/opentracing.md +++ b/specification/compatibility/opentracing.md @@ -59,9 +59,9 @@ This operation is used to create a new OpenTracing `Tracer`: This operation MUST accept the following parameters: -- An OpenTelemetry `TracerProvider`, used to get a `Tracer` with - instrumentation name and version set to `opentracing-shim` - and the shim version respectively. +- An OpenTelemetry `TracerProvider`. This operation MUST use this `TracerProvider` + to obtain a `Tracer` with the name `opentracing-shim` along with the current + shim library version. - OpenTelemetry `Propagator`s to be used to perform injection and extraction for the the OpenTracing `TextMap` and `HTTPHeaders` formats. If not specified, no `Propagator` values will be stored in the Shim, and