From cb9e92a85990e3a5405298a80314d0c83b1aa6a3 Mon Sep 17 00:00:00 2001 From: Nikita Salnikov-Tarnovski Date: Mon, 20 Sep 2021 19:42:55 +0300 Subject: [PATCH] Revert "Add InstrumentationLibrary to Sampler.ShouldSample (#1850)" This reverts commit f936f2e941ad10bf9b16b5ab15067f775f479cdb. --- CHANGELOG.md | 2 -- spec-compliance-matrix.md | 1 - specification/trace/sdk.md | 1 - 3 files changed, 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index adc810022af..402de88055b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,8 +13,6 @@ release. - Prefer global user defined limits over model-sepcific default values. ([#1893](https://github.com/open-telemetry/opentelemetry-specification/pull/1893)) -- Add InstrumentationLibrary to Sampler.ShouldSample. - ([#1850](https://github.com/open-telemetry/opentelemetry-specification/pull/1850)) ### Metrics diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index 5281aadbc32..30cf04206b6 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -75,7 +75,6 @@ formats is required. Implementing more than one format is optional. | [Sampling](specification/trace/sdk.md#sampling) | | | | | | | | | | | | | | Allow samplers to modify tracestate | | + | + | | + | + | + | | + | + | - | + | | ShouldSample gets full parent Context | | + | + | + | + | + | + | | + | + | - | + | -| ShouldSample gets InstrumentationLibrary | | | | | | | | | | | | | | [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | | + | + | - | + | | [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | | + | + | | | + | + | | + | | [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | | | | - | | + | diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index ed46bbf6df6..edaa9e63c30 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -210,7 +210,6 @@ Returns the sampling Decision for a `Span` to be created. * Collection of links that will be associated with the `Span` to be created. Typically useful for batch operations, see [Links Between Spans](../overview.md#links-between-spans). -* `InstrumentationLibrary` (name and version) of the `Span` to be created. Note: Implementations may "bundle" all or several arguments together in a single object.