diff --git a/CHANGELOG.md b/CHANGELOG.md index c30837af071..71839693df9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,8 +13,6 @@ release. - Prefer global user defined limits over model-sepcific default values. ([#1893](https://github.com/open-telemetry/opentelemetry-specification/pull/1893)) -- Add InstrumentationLibrary to Sampler.ShouldSample. - ([#1850](https://github.com/open-telemetry/opentelemetry-specification/pull/1850)) ### Metrics diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index c217ec8d2f2..0309efef956 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -75,7 +75,6 @@ formats is required. Implementing more than one format is optional. | [Sampling](specification/trace/sdk.md#sampling) | | | | | | | | | | | | | | Allow samplers to modify tracestate | | + | + | | + | + | + | | + | + | - | + | | ShouldSample gets full parent Context | | + | + | + | + | + | + | | + | + | - | + | -| ShouldSample gets InstrumentationLibrary | | | | | | | | | | | | | | [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | | + | + | - | + | | [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | | + | + | | | + | + | | + | | [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | | | | - | | + | diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index ed46bbf6df6..edaa9e63c30 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -210,7 +210,6 @@ Returns the sampling Decision for a `Span` to be created. * Collection of links that will be associated with the `Span` to be created. Typically useful for batch operations, see [Links Between Spans](../overview.md#links-between-spans). -* `InstrumentationLibrary` (name and version) of the `Span` to be created. Note: Implementations may "bundle" all or several arguments together in a single object.