From 235bcaa052b5a098d0e37d3c96d5384d38c719b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Wed, 28 Apr 2021 13:01:09 +0200 Subject: [PATCH 1/2] Add InstrumentationLibrary and Resource to ShouldSample. --- CHANGELOG.md | 2 ++ spec-compliance-matrix.md | 1 + specification/trace/sdk.md | 5 +++++ 3 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index aa2059a6381..8aa55d5f864 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,8 @@ release. ### Traces +- Add InstrumentationLibrary and Resource as Sampler arguments. ([#????](https://github.com/open-telemetry/opentelemetry-specification/pull/????)) + ### Metrics ### Logs diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md index ee90e5ef2aa..350ce73f17b 100644 --- a/spec-compliance-matrix.md +++ b/spec-compliance-matrix.md @@ -74,6 +74,7 @@ formats is required. Implementing more than one format is optional. | [Sampling](specification/trace/sdk.md#sampling) | | | | | | | | | | | | | | Allow samplers to modify tracestate | | + | + | | + | + | + | | + | | - | + | | ShouldSample gets full parent Context | | + | + | + | + | + | + | | + | + | - | + | +| ShouldSample gets Resources and InstrumentationLibrary | | | | | | | | | | | | | | [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | | + | | - | + | | [IdGenerators](specification/trace/sdk.md#id-generators) | | + | + | | + | + | | | + | | | + | | [SpanLimits](specification/trace/sdk.md#span-limits) | X | + | + | | + | + | | | | | | + | diff --git a/specification/trace/sdk.md b/specification/trace/sdk.md index e09f44b51c4..ee03df1efc1 100644 --- a/specification/trace/sdk.md +++ b/specification/trace/sdk.md @@ -206,6 +206,11 @@ Returns the sampling Decision for a `Span` to be created. * Collection of links that will be associated with the `Span` to be created. Typically useful for batch operations, see [Links Between Spans](../overview.md#links-between-spans). +* `Resource` of the `Span` to be created. +* `InstrumentationLibrary` (name and version) of the `Span` to be created. + +Note: Implementations may "bundle" all or several arguments together in a single +object. **Return value:** From c0115ac04f02ddd0e6fe5b508b9edabd26b95b0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Wed, 28 Apr 2021 13:25:42 +0200 Subject: [PATCH 2/2] Fill in PR#. --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8aa55d5f864..96f8111f6e7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ release. ### Traces -- Add InstrumentationLibrary and Resource as Sampler arguments. ([#????](https://github.com/open-telemetry/opentelemetry-specification/pull/????)) +- Add InstrumentationLibrary and Resource as Sampler arguments. ([#1658](https://github.com/open-telemetry/opentelemetry-specification/pull/1658)) ### Metrics