From c5320a4f9b34b7ef8e23267a5f7a6a8f75322896 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Tue, 3 Nov 2020 15:29:25 +0100 Subject: [PATCH 1/4] Clarify the location of tracing's Context interaction. --- specification/trace/api.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/specification/trace/api.md b/specification/trace/api.md index dff2ab9dd7c..4f1a99cd8b7 100644 --- a/specification/trace/api.md +++ b/specification/trace/api.md @@ -149,10 +149,9 @@ the following functionality: - Set the currently active span to the implicit context. This is equivalent to getting the implicit context, then inserting the `Span` to the context. All the above functionalities operate solely on the context API, and they MAY be -exposed as static methods on the trace module, as static methods on a class -inside the trace module (it MAY be named `TracingContextUtilities`), or on the -[`Tracer`](#tracer) class. This functionality SHOULD be fully implemented in the -API when possible. +exposed as either static methods on the trace module, as static methods on a class +inside the trace module, or on the [`Tracer`](#tracer) class. This functionality +SHOULD be fully implemented in the API when possible. ## Tracer From 5faaacb353e6d5ba9ed7544bc8fd46696c481c3f Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Tue, 3 Nov 2020 16:14:29 +0100 Subject: [PATCH 2/4] Update specification/trace/api.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Christian Neumüller --- specification/trace/api.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/trace/api.md b/specification/trace/api.md index 4f1a99cd8b7..3abc537ea90 100644 --- a/specification/trace/api.md +++ b/specification/trace/api.md @@ -150,7 +150,7 @@ the following functionality: All the above functionalities operate solely on the context API, and they MAY be exposed as either static methods on the trace module, as static methods on a class -inside the trace module, or on the [`Tracer`](#tracer) class. This functionality +inside the trace module. This functionality SHOULD be fully implemented in the API when possible. ## Tracer From e14324e7cfc5c4af88b288e813928a394ffd53cb Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Wed, 4 Nov 2020 12:31:28 -0800 Subject: [PATCH 3/4] Update specification/trace/api.md Co-authored-by: Nikita Salnikov-Tarnovski --- specification/trace/api.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specification/trace/api.md b/specification/trace/api.md index 3abc537ea90..4685b8e19df 100644 --- a/specification/trace/api.md +++ b/specification/trace/api.md @@ -149,7 +149,7 @@ the following functionality: - Set the currently active span to the implicit context. This is equivalent to getting the implicit context, then inserting the `Span` to the context. All the above functionalities operate solely on the context API, and they MAY be -exposed as either static methods on the trace module, as static methods on a class +exposed as either static methods on the trace module or as static methods on a class inside the trace module. This functionality SHOULD be fully implemented in the API when possible. From a48f98d5ec934af308c226ca5baa4d68174b0594 Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Wed, 4 Nov 2020 12:32:26 -0800 Subject: [PATCH 4/4] Comma and restructure of text --- specification/trace/api.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/specification/trace/api.md b/specification/trace/api.md index 4685b8e19df..fccec11df53 100644 --- a/specification/trace/api.md +++ b/specification/trace/api.md @@ -149,9 +149,8 @@ the following functionality: - Set the currently active span to the implicit context. This is equivalent to getting the implicit context, then inserting the `Span` to the context. All the above functionalities operate solely on the context API, and they MAY be -exposed as either static methods on the trace module or as static methods on a class -inside the trace module. This functionality -SHOULD be fully implemented in the API when possible. +exposed as either static methods on the trace module, or as static methods on a class +inside the trace module. This functionality SHOULD be fully implemented in the API when possible. ## Tracer