Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL_EXPORTER environment variable #710

Closed
iNikem opened this issue Jul 17, 2020 · 8 comments · Fixed by #943
Closed

Add OTEL_EXPORTER environment variable #710

iNikem opened this issue Jul 17, 2020 · 8 comments · Fixed by #943
Assignees
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:miscellaneous For issues that don't match any other spec label spec:trace Related to the specification/trace directory

Comments

@iNikem
Copy link
Contributor

iNikem commented Jul 17, 2020

What are you trying to achieve?

To simplify the configuration of auto-instrumentations via environment variables, especially for first time users, add new variable OTEL_EXPORTER as a way to configure a list of exporters to use, e.g. OTEL_EXPORTER=zipkin,prometheus,otlp_metrics

Additional context.
This issue assumes that #666 is merged and we have environment variables recommendation in spec.

@iNikem iNikem added the spec:miscellaneous For issues that don't match any other spec label label Jul 17, 2020
@Oberon00 Oberon00 added area:sdk Related to the SDK spec:trace Related to the specification/trace directory labels Jul 17, 2020
@carlosalberto
Copy link
Contributor

This would be used mostly by auto-instrumentation, right?

@iNikem
Copy link
Contributor Author

iNikem commented Jul 17, 2020

This would be used mostly by auto-instrumentation, right?

I think yes. Although, even more manual instrumentations this may be a convenient way to externalise the configuration/selection of exporters.

@bogdandrutu bogdandrutu added priority:p3 Lowest priority level and removed priority:p3 Lowest priority level labels Jul 21, 2020
@carlosalberto carlosalberto added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Jul 23, 2020
@reyang reyang added the priority:p3 Lowest priority level label Jul 24, 2020
@tigrannajaryan
Copy link
Member

I think this is a nice-to-have, not a must-have for 1.0 GA. I suggest to remove release:required-for-ga label.

@anuraaga
Copy link
Contributor

anuraaga commented Sep 9, 2020

To clarify, if the label is removed, a related PR definitely won't be merged? I don't think this, or SERVICE_NAME, are required, but if they're small in scope it could make sense to still hope they get in before GA to improve user experience of the first release.

@tigrannajaryan
Copy link
Member

If there is a PR that is ready and approved I don't see any reason not to merge it even if the label is removed.

Once a spec freeze is declared that will mean we no longer want to accept substantial changes that are not labeled as release:required-for-ga, but I think we are not yet ready to declare a freeze.

@carlosalberto carlosalberto added priority:p1 Highest priority level and removed priority:p3 Lowest priority level labels Sep 10, 2020
@carlosalberto
Copy link
Contributor

Changed it to P1 after talking to the Java Instrumentation Maintainers.

@mtwo
Copy link
Member

mtwo commented Sep 10, 2020

@anuraaga, are you able to create a PR for this?

@trask
Copy link
Member

trask commented Sep 11, 2020

i discussed with @anuraaga, please assign this to me, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:miscellaneous For issues that don't match any other spec label spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants