Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db.instance can be optional? #658

Closed
anuraaga opened this issue Jun 17, 2020 · 2 comments
Closed

db.instance can be optional? #658

anuraaga opened this issue Jun 17, 2020 · 2 comments

Comments

@anuraaga
Copy link
Contributor

I am writing some redis instrumentation that uses lettuce's native tracing support, and at least for now it doesn't expose the redis database index to tracing extensions. I have filed an issue to see if it can be added

redis/lettuce#1312

but because in Redis database index is not so common to use, and I can easily imagine other database systems without any concept of an instance / schema, does it make sense to make db.instance optional? Do we expect every single database out there to have this?

@Oberon00
Copy link
Member

Hi, can you please take a look if #575 would solve your problem?

@anuraaga
Copy link
Contributor Author

Ah sorry for missing that PR yup it looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants