Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support :? shell syntax for variable substitution #4190

Open
yurishkuro opened this issue Aug 19, 2024 · 2 comments
Open

Support :? shell syntax for variable substitution #4190

yurishkuro opened this issue Aug 19, 2024 · 2 comments
Labels
area:configuration Related to configuring the SDK sig-issue A specific SIG should look into this before discussing at the spec spec:miscellaneous For issues that don't match any other spec label triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Aug 19, 2024 •
edited
Loading

What are you trying to achieve?

Config WG merged a proposal (#3744, #3974, #3948) to support env var expansion syntax with defaults, using the traditional shell syntax VARNAME:-default. But shell syntax also commonly includes VARNAME:?error message syntax for undefined variables which was omitted. This omission is an unexpected behavior to users who are used to shell syntax.

Additional context.
@yurishkuro yurishkuro added the spec:miscellaneous For issues that don't match any other spec label label Aug 19, 2024
@yurishkuro yurishkuro mentioned this issue Aug 19, 2024
Merged
@yurishkuro yurishkuro added the area:configuration Related to configuring the SDK label Aug 19, 2024
@jack-berg
Copy link
Member

Agree that the behavior is unexpected.

Clarification on the history: Env var substitution syntax was added in #3744, extended to support ${env:ENV_VAR} in #3974, extended to support default syntax ${ENVVAR:-defaultValue} in #3948.

@jack-berg jack-berg added the sig-issue A specific SIG should look into this before discussing at the spec label Aug 19, 2024
@danielgblanco danielgblanco added the triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned label Aug 26, 2024
@danielgblanco
Copy link
Contributor

@jack-berg as you're part of the config SIG we (@jpkrohling and I) are assuming you're the sponsor. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:configuration Related to configuring the SDK sig-issue A specific SIG should look into this before discussing at the spec spec:miscellaneous For issues that don't match any other spec label triage:accepted:ready-with-sponsor Ready to be implemented and has a specification sponsor assigned
Projects
Declarative Configuration Stability
Status: Not blocking stability
🔭 Main Backlog
Status: Spec - Accepted
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yurishkuro @danielgblanco @jack-berg