Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Extend Logs Bridge API instead of creating separate Events API #3828

Closed
pellared opened this issue Jan 16, 2024 · 1 comment
Closed
Assignees
Labels
spec:logs Related to the specification/logs directory

Comments

@pellared
Copy link
Member

pellared commented Jan 16, 2024

Would it not make sense to make the Logs (Bridge) API useable for creating events?

The Events API has only one additional parameter which is the "event name".

Couldn't we add EventName to the Bridge API's Emit Record and just call out the differences in the API implementation when it is set?

EDIT: I see that this is a counter-issue for #3086.

@pellared pellared added the spec:logs Related to the specification/logs directory label Jan 16, 2024
@pellared
Copy link
Member Author

pellared commented Jan 16, 2024

Never mind. I think that it makes sense to have it as a separate API because it serves a different use-case and the APIs may evolve orthogonally.

Unlike the Logs Bridge API, application developers and instrumentation authors are encouraged to call this API directly.

At first glance it looks suspicious as the APIs look almost identical.

@pellared pellared changed the title Proposal: Extend bridge API instead of creating seperate API for events Proposal: Extend Logs Bridge API instead of creating separate Events API Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:logs Related to the specification/logs directory
Projects
None yet
Development

No branches or pull requests

2 participants