Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote sampling specification for proto layout #372

Open
annanay25 opened this issue Dec 5, 2019 · 3 comments
Open

Remote sampling specification for proto layout #372

annanay25 opened this issue Dec 5, 2019 · 3 comments
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory

Comments

@annanay25
Copy link

Per @jmacd's comment here - open-telemetry/opentelemetry-collector#432 (comment) - since remote sampling configuration (for both metrics and traces) is on the roadmap for OpenTelemetry, creating this issue as a placeholder for discussion on the specification for proto layout.

@bogdandrutu
Copy link
Member

In OpenCensus we had something but was not fully backed and used, but you can take a look at the proto repo config package.

@yurishkuro
Copy link
Member

I would separate support for the existing Jaeger format (if desired to expose it) from the design of a new format. We have started building support for user-configured adhoc sampling rules in Jaeger, which require much more generic remote config than what we have today.

@Oberon00
Copy link
Member

Oberon00 commented Mar 3, 2020

Hey, I'm not sure I understand what this issue really is about? What's that about "layout" in the title? Maybe a better title can be found?

@jmacd jmacd added the area:sampling Related to trace sampling label May 29, 2020
@bogdandrutu bogdandrutu added the spec:trace Related to the specification/trace directory label Jun 12, 2020
@reyang reyang added the area:sdk Related to the SDK label Jun 30, 2020
@carlosalberto carlosalberto added the release:after-ga Not required before GA release, and not going to work on before GA label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

7 participants