-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP SemConv transition plan is not extensible #3488
HTTP SemConv transition plan is not extensible #3488
Comments
It should also be documented in specification/configuration/sdk-environment-variables.md |
Wasn't that exactly the point behind this env var? |
If you click through the link in the OP you will see that may not be the case. |
this was an earlier plan, but it changed last week to support future csv values
this is a great point, I'll send a PR to fix this |
I'm not sure about this since it's not an SDK environment variable
I've sent #3492 👍 |
If this is supposed to be extensible, should we remove the
part then? I am not convinced that we can stabilize (let alone implement) messaging semconv before October. Also, what's going to happen when we do release a 2.0 instrumentation package? If the env var stays, should the |
Not just messaging. This will likely be an ongoing concern for a long time as we stabilize all the semconv
I would think so |
(I know that #3443 has my approval on it, but I approved the previous version of that warning) @trask I think that warning (and env var) as it is now is rather confusing for instrumentation maintainers, as it mixes several the HTTP-specific concerns and the general usage of the env var.
I think these two points should be rephrased so that they only apply to the |
The HTTP SemConv transition plan defines an environment variable with potential values
http
,http/dup
, etc. It is my understanding that the plans for future semconv areas like messaging will add additional possible values to this environment variable ( e.g.OTEL_SEMCONV_STABILITY_OPT_IN =http/dup/messaging
) source.After the transition plan merged, it was pointed out to me by @Flarna that the variable requires a predefined method for multiple values such as comma-separated values. Otherwise an implementation which simply checks
env.OTEL_SEMCONV_STABILITY_OPT_IN == "http"
or uses a switch/case will be broken in the case that multiple values exist as in the example above.Action items:
/cc @trask
The text was updated successfully, but these errors were encountered: