Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace http.url and http.target in http metric conventions #2335

Closed
trask opened this issue Feb 10, 2022 · 0 comments · Fixed by #2818
Closed

Replace http.url and http.target in http metric conventions #2335

trask opened this issue Feb 10, 2022 · 0 comments · Fixed by #2818
Assignees
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory

Comments

@trask
Copy link
Member

trask commented Feb 10, 2022

What are you trying to achieve?

Consistency between trace and metric attributes.

As the http metric conventions mention, http.url and http.target values cannot be the same for metrics as for traces, since these attributes are high-cardinality. So the http metric conventions say to reduce the cardinality of http.url and http.target, but still use those attribute names.

What did you expect to see?

An alternative would be to use the identifying sets of attributes from the http client and server trace conventions, with http.target replaced by http.route, and with http.route being optional since it's not always available, e.g.

For both server/client metrics, capture http.route if it's available.

And for http server metrics, at least one of the following sets of attributes is required:

And for http client metrics, at least one of the following sets of attributes is required:

@trask trask added the spec:metrics Related to the specification/metrics directory label Feb 10, 2022
@arminru arminru added area:semantic-conventions Related to semantic conventions semconv:HTTP labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants