-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading semantic convention tables is cumbersome #1925
Comments
How important is it to even have the table? Looking at the examples you provided, not only do you need to scroll the table, but the formatting is also 80% whitespace. A bullet-list format would've been more compact:
And it allows more flexibility in adding clarifications / footnotes directly |
I would use one bullet-point per attribute. Using a bullet-point per field per-attribute may be too much noise. E.g. your example I would write as:
Or even more compact:
Non-required attributes would leave out the word "required". |
Github now has native support for footnotes: https://github.blog/changelog/2021-09-30-footnotes-now-supported-in-markdown-fields/. Depending on how exactly things end up, they might provide a bit better experience versus plain text |
I'd rather get rid of any footnote-like formatting completely. They are not really footnotes but often integral part of the attribute definition, where the text is just too long to reasonably fit in the table. |
(This has to be implemented in https://github.com/open-telemetry/build-tools/tree/main/semantic-conventions but affects mostly the spec and needs discussion, so opening issue here)
The current presentation of the semantic convention attribute tables has a few problems:
destination_kind
attribute.[1]
,[2]
etc. If you read the note, it is often not obvious to which attribute it belongs. This makes it impossible to read a semantic convention from top to bottom without scrolling up and down constantly. E.g. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/messaging.md#messaging-attributesWorst case currently is that you have a enum with a note and a condition and enum members can have a note as well. Sample UX:
I would like to have a presentation that you can read in a single pass without cross-referencing stuff below the table and inside the table. For example, this could be a presentation as a list, so there is enough space to inline the notes and enum definitions. This could be complemented by a (very) short list of attributes with links at the top.
The text was updated successfully, but these errors were encountered: