-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTEL_SERVICE_VERSION #1901
Comments
Raising this again, we (Honeycomb) also utilise this field and would like to see it as a formal environment variable in the spec. |
Related to #3025 We could allow setting resource attributes usingfollowing pattern |
If we do anything with dynamic env var names, it should align with what we're doing in the config SIG. |
I wouldn't rush also with specific environment names, otherwise there will be 3 different ways and 3 different priorities for the same thing. |
So we already have the very related |
I take it you mean
I am interested, 💯 we should have this, what's there to discuss? its in fact weird to have support to configure the svc name via env var but not the service version. every lang can just take what they do with OTEL_SERVICE_NAME and repeat the pattern with OTEL_SERVICE_VERSION, bingo bango done |
hi @naseemkullah! check out #2891 (comment) and see #3752 for concrete reasons why we don't want to introduce any new env vars at this point you will be able to set |
We're gonna close this because at this point we do not wish to introduce any new environment variables, and the forthcoming config work will render the issue moot (as you will be able to set the value there, as seen in @trask's comment) |
Similarly to OTEL_SERVICE_NAME, I was wondering if we could add this one as well (for context, we at Lightstep leverage this and currently have to use our own custom env var).
I do remember a conversation back in the day (I think @bogdandrutu and @Oberon00 chimed in) when it came to what made
OTEL_SERVICE_NAME
special, and its siblings not (service namespace, service version). Happy to discuss!The text was updated successfully, but these errors were encountered: