Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jaeger's "firehose" flag. #1226

Open
toumorokoshi opened this issue Nov 13, 2020 · 4 comments
Open

Support for Jaeger's "firehose" flag. #1226

toumorokoshi opened this issue Nov 13, 2020 · 4 comments
Labels
area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory

Comments

@toumorokoshi
Copy link
Member

What are you trying to achieve?

Have a discussion to see if we should modify the spec to support setting Jaeger's firehose flag.

What did you expect to see?

From what I can see, the current spec does not explicitly state that users can set custom flags on the TraceFlags attribute. Since custom flags are not possible, users cannot set any flags aside from "Sampled". This means that Jaeger's firehose flag (represented in their flags as 0b100) cannot be set.

Additional context.

This came up while implementing jaeger's propagator in python.

I was also wondering if propagation of the flag is required to child spans, but the pr adding it to jaeger seems to imply it's set on a per-span basis.

@toumorokoshi toumorokoshi added the spec:trace Related to the specification/trace directory label Nov 13, 2020
@toumorokoshi
Copy link
Member Author

Actually, it looks like I missed some behavior. Looking at the go client, Jaeger actually propagates the TraceFlags to child spans. We would have to modify the spec to explicitly propagate all TraceFlags down to children, rathe than the current:

* `Sampled` flag in `TraceFlags` on `SpanContext`. This flag is propagated via
  the `SpanContext` to child Spans. For more details see the [W3C Trace Context
  specification](https://www.w3.org/TR/trace-context/#sampled-flag). This flag indicates that the `Span` has been

@Oberon00
Copy link
Member

Oberon00 commented Nov 13, 2020

I think this should be implemented the same way as the B3 debug flag, i.e. it should be stored on the Context not the SpanContext (#1045 )

@andrewhsu andrewhsu added the release:after-ga Not required before GA release, and not going to work on before GA label Nov 13, 2020
@andrewhsu
Copy link
Member

from the issue triage session today, @yurishkuro this is initially triaged as after-ga. please comment if it should be addressed before.

@yurishkuro
Copy link
Member

sgtm. Firehose flag is not widely used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

4 participants