Replies: 1 comment
-
Sorry, now following the contribution workflow - #3006 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I believe the text below from the spec misleading.
The text makes me think that if any of these APIs (AddEvent, SetAttribute..) are called, the recording status will be TRUE. Seems like
IsRecording
returns True if the Span is sampled and the sample hasn't ended. At least the go implementation tells me that.I believe the current text is valuable but needs to be added in a way that none of these APIs (AddEvent, SetAttribute..) will work (in other terms will be NOOP) after the span is ended. I would be happy to send a patch if I have a point.
Beta Was this translation helpful? Give feedback.
All reactions