From f9041d2bc3f37b67adf198affde76a5e6130c47c Mon Sep 17 00:00:00 2001 From: skonto Date: Mon, 28 Jun 2021 16:12:34 +0300 Subject: [PATCH] fixes --- specification/metrics/semantic_conventions/faas-metrics.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/specification/metrics/semantic_conventions/faas-metrics.md b/specification/metrics/semantic_conventions/faas-metrics.md index b28c802ebf9..033f27a91b4 100644 --- a/specification/metrics/semantic_conventions/faas-metrics.md +++ b/specification/metrics/semantic_conventions/faas-metrics.md @@ -49,7 +49,7 @@ Optionally, when applicable: ## Labels -Below is a table of the labels that SHOULD be included on FaaS metric events. +Below is a table of the labels to be included on FaaS metric events. | Name | Recommended | Notes and examples | |------|-------------|--------------------| @@ -58,7 +58,10 @@ Below is a table of the labels that SHOULD be included on FaaS metric events. | `faas.invoked_provider` | Yes | Cloud provider of the invoked function. Corresponds to the resource `cloud.provider`. Example: `aws` | | `faas.invoked_region` | Yes | Cloud provider region of invoked function. Corresponds to resource `cloud.region`. Example: `us-east-1` | -More details on these labels and the function name and the difference compared to the faas.invoked_name can be found at the related [faas tracing specification](../../trace/semantic_conventions/faas.md). +More details on these labels, the function name and the difference compared to the faas.invoked_name can be found at the related [FaaS tracing specification](../../trace/semantic_conventions/faas.md). +For incoming FaaS executions, the function for which metrics are reported is already described by its [FaaS resource attributes](../../resource/semantic_conventions/faas.md). +Outgoing FaaS executions are identified using the `faas.invoked_*` attributes above. +`faas.trigger` SHOULD be included in all metric events while `faas.invoked_*` attributes apply on outgoing FaaS execution events only. ## References