From 6857b055dfa2a773141b09815bb5ba4367a3d15c Mon Sep 17 00:00:00 2001 From: songy23 Date: Fri, 14 Jun 2019 16:00:23 -0700 Subject: [PATCH] Update default samplers, links and StartSpan. --- specification/tracing-api.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/specification/tracing-api.md b/specification/tracing-api.md index ea9dba42faf..d823aeb8f8d 100644 --- a/specification/tracing-api.md +++ b/specification/tracing-api.md @@ -195,8 +195,9 @@ Optional parameters (or corresponding setters on `Builder` if using a `Builder` - The option to become a root `Span` for a new trace. If not set, the value of [Tracer.getCurrentSpan](#getcurrentspan) at `StartSpan` time will be used as parent. -- `Sampler` to the newly created `Span`. If not set, the implementation should provide a default. -- `Link` to the newly created `Span`. +- `Sampler` to the newly created `Span`. If not set, the implementation should provide a +default sampler used by Tracer. +- Collection of `Link`s that will be associated with the newly created Span - The override value for [a flag indicating whether events should be recorded](#isrecordingevents) for the newly created `Span`. If not set, the implementation will provide a default. - `SpanKind` for the newly created `Span`. If not set, the implementation will @@ -206,7 +207,7 @@ Optional parameters (or corresponding setters on `Builder` if using a `Builder` Starts a new `Span`. -This MUST not be called multiple times with `Builder` pattern. +If called multiple times with `Builder` pattern, the same `Span` will be returned. There should be no parameter if using a `Builder` pattern. Otherwise, `StartSpan` should accept all the optional parameters described in [Span creation](#span-creation).