From 5b37817fba0c0e1b8de64d16d900946773c49d79 Mon Sep 17 00:00:00 2001 From: Mike Dame Date: Mon, 10 Apr 2023 17:56:45 +0000 Subject: [PATCH] Add detail for GCP Cloud Run Job version --- semantic_conventions/resource/faas.yaml | 11 +++++++++-- specification/resource/semantic_conventions/faas.md | 11 +++++++++-- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/semantic_conventions/resource/faas.yaml b/semantic_conventions/resource/faas.yaml index 4a7d3e4f306..06c32638e31 100644 --- a/semantic_conventions/resource/faas.yaml +++ b/semantic_conventions/resource/faas.yaml @@ -36,8 +36,15 @@ groups: * **AWS Lambda:** The [function version](https://docs.aws.amazon.com/lambda/latest/dg/configuration-versions.html) (an integer represented as a decimal string). - * **Google Cloud Run:** The [revision](https://cloud.google.com/run/docs/managing/revisions) - (i.e., the function name plus the revision suffix). + * **Google Cloud Run:** + * **Services:** The + [revision](https://cloud.google.com/run/docs/managing/revisions) (i.e., + the function name plus the revision suffix). + * **Jobs:** The + [execution](https://cloud.google.com/run/docs/managing/job-executions) and + [task + index](https://cloud.google.com/run/docs/container-contract#jobs-env-vars), + eg `execution/0`. * **Google Cloud Functions:** The value of the [`K_REVISION` environment variable](https://cloud.google.com/functions/docs/env-var#runtime_environment_variables_set_automatically). * **Azure Functions:** Not applicable. Do not set this attribute. diff --git a/specification/resource/semantic_conventions/faas.md b/specification/resource/semantic_conventions/faas.md index b707bbf0f6c..c350fcbef69 100644 --- a/specification/resource/semantic_conventions/faas.md +++ b/specification/resource/semantic_conventions/faas.md @@ -42,8 +42,15 @@ definition of function name MUST be used for this attribute * **AWS Lambda:** The [function version](https://docs.aws.amazon.com/lambda/latest/dg/configuration-versions.html) (an integer represented as a decimal string). -* **Google Cloud Run:** The [revision](https://cloud.google.com/run/docs/managing/revisions) - (i.e., the function name plus the revision suffix). +* **Google Cloud Run:** + * **Services:** The + [revision](https://cloud.google.com/run/docs/managing/revisions) (i.e., + the function name plus the revision suffix). + * **Jobs:** The + [execution](https://cloud.google.com/run/docs/managing/job-executions) and + [task + index](https://cloud.google.com/run/docs/container-contract#jobs-env-vars), + eg `execution/0`. * **Google Cloud Functions:** The value of the [`K_REVISION` environment variable](https://cloud.google.com/functions/docs/env-var#runtime_environment_variables_set_automatically). * **Azure Functions:** Not applicable. Do not set this attribute.