Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage github action #320

Merged
merged 15 commits into from
Oct 31, 2020
Merged

Add code coverage github action #320

merged 15 commits into from
Oct 31, 2020

Conversation

jtescher
Copy link
Member

Pull out nightly tests into a new CI run that includes test coverage using grcov and codecov

Resolves #318

@jtescher jtescher requested a review from a team October 30, 2020 03:54
@codecov
Copy link

codecov bot commented Oct 30, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@be76c0a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #320   +/-   ##
=========================================
  Coverage          ?   41.11%           
=========================================
  Files             ?       73           
  Lines             ?     8615           
  Branches          ?        0           
=========================================
  Hits              ?     3542           
  Misses            ?     5073           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be76c0a...a5e631e. Read the comment docs.

TommyCpp
TommyCpp approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jtescher
Copy link
Member Author

Want to see if I can get the otlp/prometheus exporters in here too, something about grpcio is having issues with the coverage flags. If not can get things started here and improve in subsequent PRs.

drexler
drexler reviewed Oct 31, 2020
View reviewed changes
.github/workflows/ci.yml
CARGO_INCREMENTAL: '0'
RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
RUSTDOCFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
- uses: actions-rs/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the latest version of grcov here - v0.1.5

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the latest? (v0.1 is pointing at same as v0.1.6) https://github.com/actions-rs/grcov/tags

@jtescher
Copy link
Member Author

Ok going to merge this for now to get a coverage baseline.

@jtescher jtescher merged commit 2574dd5 into master Oct 31, 2020
@jtescher jtescher deleted the code-coverage branch October 31, 2020 21:54
@jtescher jtescher mentioned this pull request Nov 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drexler drexler drexler left review comments

@TommyCpp TommyCpp TommyCpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code coverage reporting
3 participants
@jtescher @drexler @TommyCpp