Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Exporter: Counters should have _total suffix #926

Closed
dashpole opened this issue Dec 6, 2022 · 1 comment
Closed

Prometheus Exporter: Counters should have _total suffix #926

dashpole opened this issue Dec 6, 2022 · 1 comment
Labels
A-metrics Area: issues related to metrics bug Something isn't working

Comments

@dashpole
Copy link

dashpole commented Dec 6, 2022

From the OTel prometheus spec:

Monotonic Sum metric points MUST have _total added as a suffix to the metric name.

The current implementation doesn't add a suffix to prometheus counter metrics.
@TommyCpp TommyCpp added bug Something isn't working A-metrics Area: issues related to metrics labels Dec 11, 2022
@zengxilong zengxilong mentioned this issue Jan 19, 2023
Merged
@TommyCpp
Copy link
Contributor

close with #952

@dashpole dashpole mentioned this issue Jun 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-metrics Area: issues related to metrics bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dashpole @TommyCpp