Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integration test to cover key OTLP scenarios #2401

Open
cijothomas opened this issue Dec 9, 2024 · 6 comments · Fixed by #2432
Open

Use integration test to cover key OTLP scenarios #2401

cijothomas opened this issue Dec 9, 2024 · 6 comments · Fixed by #2432
Assignees
Milestone

Comments

@cijothomas
Copy link
Member

cijothomas commented Dec 9, 2024

Pre-req to #2142
We should improve the existing integration tests to add coverage for OTLP under various combinations of ExportProcessor/PeriodicReader and the networking library (reqwest/hyper/tonic).

The test infra already exists, but it is missing few things

  1. Metric is untested - Done refactor integration tests and add metrics coverage #2432
  2. Simple processor scenarios not covered.
  3. tokio::main vs normal main
  4. Any missing combinations.
  5. reqwest-blocking support is not working, and commented out -
    # cargo test --no-default-features --features "reqwest-blocking-client" -- --ignored
    . Need to be fixed.
@cijothomas cijothomas added this to the 0.28.0 milestone Dec 9, 2024
@scottgerring
Copy link
Contributor

Hey @cijothomas , I can take this one. Good opportunity to get into the code some more 🙌

@cijothomas
Copy link
Member Author

Thanks! As mentioned offline, please start with adding Metrics (which is completely missing now), and then you can continue with the rest.

@lalitb
Copy link
Member

lalitb commented Dec 10, 2024

Also, reqwest-blocking doesn't work as of now, and so is commented out from test. This could be for being called from within the async context. Added it to the description to make it complete. -

# TODO - Uncomment the following lines once the reqwest-blocking-client feature is working.
# cargo test --no-default-features --features "reqwest-blocking-client" -- --ignored

@cijothomas
Copy link
Member Author

Also, reqwest-blocking doesn't work as of now, and so is commented out from test. This could be for being called from within the async context.

Yes, should be fixable with
#2400

@scottgerring
Copy link
Contributor

Perfect! I'll get stuck in tail end of this week.

@cijothomas
Copy link
Member Author

Re-opening as this is good to be kept as the parent issue tracking good coverage via integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants