Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export otel.status_code tag in Zipkin exporter #223

Closed
jtescher opened this issue Sep 21, 2020 · 3 comments
Closed

Export otel.status_code tag in Zipkin exporter #223

jtescher opened this issue Sep 21, 2020 · 3 comments

Comments

@jtescher
Copy link
Member

See the spec change for details (may not be exported currently).

@danrusei
Copy link
Contributor

can't the otel.status_code & otel.status_description be added to tags (into_zipkin_span function) ?

tags.insert("otel.status_code".into(), span_data.status_code.to_string());
tags.insert("otel.status_description".into(), span_data.status_message.clone());

Display has to be implemented for StatusCode enum.

@jtescher
Copy link
Member Author

@danrusei yeah should be easy to add, I don't think that anything else needs to format status codes that way, I believe the other exports use the numeric values. Could just add a function from StatusCode -> &'static str that formats the way zipkin expects maybe?

@jtescher
Copy link
Member Author

jtescher commented Oct 6, 2020

Resolved in #236

@jtescher jtescher closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants