Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTEL_EXPORTER environment variable #220

Closed
jtescher opened this issue Sep 16, 2020 · 4 comments
Closed

Support OTEL_EXPORTER environment variable #220

jtescher opened this issue Sep 16, 2020 · 4 comments

Comments

@jtescher
Copy link
Member

See the spec change for details.

@TommyCpp
Copy link
Contributor

TommyCpp commented Sep 22, 2020

I think it's gonna be a tricky one. The PR doesn't include support for external/vendor exporters but all our exporter feels like external exporters since they don't live in the main create.

May need to use Marcos to generate code to configure exporter based on what's available in dependencies.

@jtescher
Copy link
Member Author

@TommyCpp yeah good point. Maybe we hold off on this one until we see if any other language implements this. Could look at what is available, or have another crate that depends on all the standard exporters which adds this functionality, none of these seem like great options currently though.

@TommyCpp
Copy link
Contributor

TommyCpp commented Oct 6, 2020

open-telemetry/opentelemetry.io#4348 seems to conclude that this should be a optional env. If that's the case we could just don't implement it.

@jtescher
Copy link
Member Author

jtescher commented Oct 6, 2020

@TommyCpp sounds good, closing for now. If folks want this we can re-open later.

@jtescher jtescher closed this as completed Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants