SpanAttribute key deduplication #1284
Assignees
Labels
A-trace
Area: issues related to tracing
Comments
|
Related to similar issue specifically for Metrics : #1098 |
cijothomas
changed the title
|
Closed with #1293, with a near 50% performance improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LogRecord has switched from HashMap(OrderMap to be precise) to simple Vector to attributes to achieve significant perf gains.
Span is currently using HashMap(OrderMap), and want to gain more opinions on moving this to simple Vector as well. There was some argument for keeping HashMap to keep O(1) lookup as requested here : #794.
The performance benchmarks in this PR have presented the case for switching to Vector. The PR, which added benchmarks got merged, but there was no issue to track making the actual changes!
This issue is opened to track changing the HashMap/OrderMap to vectors, and remove the SDK from doing the de-duplication. It is still possible to make an opt-in feature to do this (as a processor or even at exporter thread to not affect user thread), if we there is enough demand for such a feature.
Related to #1283 as well.
The text was updated successfully, but these errors were encountered: