Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs API/SDK - Move LogRecord implementation details from API to SDK #1189

Closed
lalitb opened this issue Aug 7, 2023 · 0 comments · Fixed by #1702
Closed

Logs API/SDK - Move LogRecord implementation details from API to SDK #1189

lalitb opened this issue Aug 7, 2023 · 0 comments · Fixed by #1702
Assignees
@lalitb
Labels
A-log Area: Issues related to logs priority:p2 Medium priority issues and bugs. release:required-for-stable Must be resolved before GA release, or nice to have before GA. triage:accepted Has been triaged and accepted. version:breaking Tag PR which will make breaking changes. Same as bumping the "major" in semver. https://semver.org/
Milestone
Logging Bridge AP...

Comments

@lalitb
Copy link
Member

lalitb commented Aug 7, 2023 •
edited
Loading

As of now, the Logs API contains the implementation details for creation of LogRecord object. This should be ideally moved to SDK. The API should have minimal implementation details and storage allocation, and hence minimal performance overhead. Anyone wanting to create custom logs SDK will otherwise have to bear the baggage of these allocations happening in API.

This is also how trace signal is implemented, API has a Span trait, and it's Noop implementation, while the implementation details are in the Span structure in SDK.
@lalitb lalitb self-assigned this Aug 7, 2023
@cijothomas cijothomas added the A-log Area: Issues related to logs label Aug 7, 2023
@TommyCpp TommyCpp added priority:p2 Medium priority issues and bugs. triage:accepted Has been triaged and accepted. version:breaking Tag PR which will make breaking changes. Same as bumping the "major" in semver. https://semver.org/ labels Aug 8, 2023
@cijothomas cijothomas mentioned this issue Oct 3, 2023
Closed
@lalitb lalitb mentioned this issue Nov 2, 2023
Closed
@cijothomas cijothomas mentioned this issue Feb 2, 2024
Closed
@cijothomas cijothomas mentioned this issue Feb 15, 2024
Closed
@hdost hdost added this to the Logging Bridge API Stable milestone Feb 21, 2024
@hdost hdost added the release:required-for-stable Must be resolved before GA release, or nice to have before GA. label Feb 21, 2024
@cijothomas cijothomas mentioned this issue Feb 23, 2024
Open
@lalitb lalitb mentioned this issue May 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalitb lalitb

Labels
A-log Area: Issues related to logs priority:p2 Medium priority issues and bugs. release:required-for-stable Must be resolved before GA release, or nice to have before GA. triage:accepted Has been triaged and accepted. version:breaking Tag PR which will make breaking changes. Same as bumping the "major" in semver. https://semver.org/
Projects
None yet
Milestone
Logging Bridge API Stable
Development

Successfully merging a pull request may close this issue.

Moving LogRecord implementation to SDK lalitb/opentelemetry-rust
4 participants
@hdost @lalitb @cijothomas @TommyCpp