New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing HttpToStatus from API/core #809

Closed

carlosalberto opened this issue Jun 9, 2021 · 1 comment · Fixed by #805

Assignees

Labels

spec-compliance

Milestone

carlosalberto commented Jun 9, 2021

https://github.com/open-telemetry/opentelemetry-ruby/blob/main/api/lib/opentelemetry/trace/util/http_to_status.rb defines util logic around http codes, which is logically closer to instrumentation, which in turn is not yet stable. Consider removing it from the core package and putting it in a contrib/extra one.

Contributor

fbogsany commented Jun 10, 2021

👍 it's incorrect anyway. I'll remove it altogether in #805.

fbogsany linked a pull request

that will close this issue

fix!: total order constraint on span.status= #805

Merged

fbogsany added this to the Tracing v1.0 milestone

fbogsany added the spec-compliance label

fbogsany self-assigned this

fbogsany closed this as completed in #805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment