Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we are returning no-op span according to clarified requirements #1255

Closed
ahayworth opened this issue May 11, 2022 · 3 comments
Closed
Labels
spec-compliance/v1.9.0 spec-compliance Required for OpenTelemetry spec compliance

Comments

@ahayworth
Copy link
Contributor

I'm not sure if we're actually doing this right or not, I haven't stared at it long enough yet: open-telemetry/opentelemetry-specification#2121

@ahayworth ahayworth added spec-compliance Required for OpenTelemetry spec compliance spec-compliance/v1.9.0 labels May 11, 2022
@fbogsany
Copy link
Contributor

This only applies to the no-op API implementation in the absence of a SDK. Our implementation conforms to the spec:

def start_span(name, with_parent: nil, attributes: nil, links: nil, start_timestamp: nil, kind: nil)
span = OpenTelemetry::Trace.current_span(with_parent)
if span.context.valid?
span
else
Span::INVALID
end
end
.

@fbogsany
Copy link
Contributor

Further clarification here: our API Span is implicitly non-recording, so if we have a valid Span in the context, we return it.

@ahayworth
Copy link
Contributor Author

Fantastical. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-compliance/v1.9.0 spec-compliance Required for OpenTelemetry spec compliance
Projects
Status: Done
Development

No branches or pull requests

2 participants