Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Explicit Dependencies on ActiveSupport Core Extentions #705

Closed
arielvalentin opened this issue Oct 21, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@arielvalentin
Copy link
Collaborator

Description of the bug

Rails 7.1 is no longer auto-loading some core language extensions1, however we have a few instances of our instrumentation depending on those methods.

We must not rely on dependencies from any gem outside of the Ruby standard library.

This is causing errors for some of our end users who are in the process of upgrading to Rails 7.1:

ERROR -- : OpenTelemetry error: unexpected configuration error due to undefined method `blank?' for "eu-west-1":String - OpenTelemetry::SDK::ConfigurationError

I had replaced the usage of blank? in the gruf gem when adding test coverage for Rails 7.1 but it seems we still have references in at least the grape instrumentation.

cc: @muripic for Grape

Share details about your runtime

Ruby 3.2
Rails 7.1

Footnotes

  1. https://github.com/rails/rails/commit/0170745b376acd150fec5f8cc57253cc1ffe0cf2

@arielvalentin arielvalentin added the bug Something isn't working label Oct 21, 2023
@muripic
Copy link
Contributor

muripic commented Oct 23, 2023

Thanks for flagging, @arielvalentin ! I'll try to submit a PR fixing this today 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants