You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using https://github.com/basecamp/marginalia gem to prefix SQL queries with annotations, the Span name no longer contains the operation. For example, prior to prefixing I would see SELECT my_db now I just see my_db and the operation attribute is missing.
I suspect it's because the extract_operation method does not take comments into consideration.
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.
Description of the bug
When using https://github.com/basecamp/marginalia gem to prefix SQL queries with annotations, the Span name no longer contains the operation. For example, prior to prefixing I would see
SELECT my_db
now I just seemy_db
and theoperation
attribute is missing.I suspect it's because the extract_operation method does not take comments into consideration.
Share details about your runtime
Operating system details: Linux, Debian 11 LTS
RUBY_ENGINE: "ruby"
RUBY_VERSION: "3.1.3"
RUBY_DESCRIPTION: "ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [aarch64-linux]"
Share a simplified reproduction if possible
The text was updated successfully, but these errors were encountered: