From 670c8a35a4b13079d69c5eefbda70516014377f9 Mon Sep 17 00:00:00 2001 From: disfluxly <31159882+disfluxly@users.noreply.github.com> Date: Tue, 3 Mar 2020 11:36:13 -0500 Subject: [PATCH 1/2] Usage README Update for opentelemetry-ext-jaeger Usage docs for opentelemetry-ext-jaeger need to be updated after the change to `TracerSource` with v0.4. Looks like it was partially updated already. Users following the usage docs will currently run into this error: `AttributeError: 'Tracer' object has no attribute 'add_span_processor'` --- ext/opentelemetry-ext-jaeger/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/opentelemetry-ext-jaeger/README.rst b/ext/opentelemetry-ext-jaeger/README.rst index 04f7c4082b5..900e2898b73 100644 --- a/ext/opentelemetry-ext-jaeger/README.rst +++ b/ext/opentelemetry-ext-jaeger/README.rst @@ -56,7 +56,7 @@ gRPC is still not supported by this implementation. span_processor = BatchExportSpanProcessor(jaeger_exporter) # add to the tracer - tracer.add_span_processor(span_processor) + trace.tracer_source().add_span_processor(span_processor) with tracer.start_as_current_span('foo'): print('Hello world!') From ac73e7b25e6f6f296632f0d55bd8087e1bd3cd63 Mon Sep 17 00:00:00 2001 From: disfluxly <31159882+disfluxly@users.noreply.github.com> Date: Tue, 3 Mar 2020 12:25:10 -0500 Subject: [PATCH 2/2] Update ext/opentelemetry-ext-jaeger/README.rst https://github.com/open-telemetry/opentelemetry-python/pull/459#discussion_r387162632 Co-Authored-By: alrex --- ext/opentelemetry-ext-jaeger/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/opentelemetry-ext-jaeger/README.rst b/ext/opentelemetry-ext-jaeger/README.rst index 900e2898b73..6813fbdeee8 100644 --- a/ext/opentelemetry-ext-jaeger/README.rst +++ b/ext/opentelemetry-ext-jaeger/README.rst @@ -56,7 +56,7 @@ gRPC is still not supported by this implementation. span_processor = BatchExportSpanProcessor(jaeger_exporter) # add to the tracer - trace.tracer_source().add_span_processor(span_processor) + trace.tracer_provider().add_span_processor(span_processor) with tracer.start_as_current_span('foo'): print('Hello world!')