Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API to add links to span #994

Closed
codeboten opened this issue Aug 17, 2020 · 1 comment
Closed

API to add links to span #994

codeboten opened this issue Aug 17, 2020 · 1 comment
Assignees
@lzchen
Labels
api Affects the API package. good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release

Comments

@codeboten
Copy link
Contributor

To be compliant with the tracing spec, we need an API to add links to span

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/api.md#span
@codeboten codeboten added good first issue Good first issue api Affects the API package. help wanted release:required-for-ga To be resolved before GA release labels Aug 17, 2020
@lzchen lzchen mentioned this issue Aug 17, 2020
Closed
@lzchen lzchen self-assigned this Aug 18, 2020
@lzchen
Copy link
Contributor

lzchen commented Aug 18, 2020

Looking at the specs more clearly and seeing other languages implementations, it seems that link adding only occurs during creation of the span so an API method to explicitly add them is not needed.

@lzchen lzchen closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
api Affects the API package. good first issue Good first issue help wanted release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @lzchen