Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect StartTimeUnixNano for ExponentialBucketHistogram with Delta Temporality after empty collection #4037

Closed
ocelotl opened this issue Jul 9, 2024 · 0 comments · Fixed by #3978
Assignees
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 9, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)

What happened?

Same as reported in #4008 but for ExponentialBucketHistogramAggregation.

Steps to Reproduce

I'll add a test case that fails in main.

Expected Result

start_time_unix_nano being greater than the previous collected point time_unix_nano when there is a time delay between the two points and an empty collection in between them as well.

We should be doing this:

(T0, T1]
  - attributes: {verb = GET, status = 200}, count: 2, min: 50 (ms), max: 100 (ms)
  - attributes: {verb = GET, status = 500}, count: 1, min: 1 (ms), max: 1 (ms)
(T1, T2]
  - nothing since we don't have any Measurement received
(T2, T3]
  - attributes: {verb = GET, status = 500}, count: 2, min: 2 (ms), max: 5 (ms)

Actual Result

start_time_unix_nano being the same as the previous collected point time_unix_nano when there is a time delay between the two points and an empty collection in between them as well.

We are doing this:

(T0, T1]

  - attributes: {verb = GET, status = 200}, count: 2, min: 50 (ms), max: 100 (ms)

  - attributes: {verb = GET, status = 500}, count: 1, min: 1 (ms), max: 1 (ms)

(T1, T2]

  - nothing since we don't have any Measurement received

(T1, T3]

  - attributes: {verb = GET, status = 500}, count: 2, min: 2 (ms), max: 5 (ms)

Additional context

No response

Would you like to implement a fix?

None

@ocelotl ocelotl added the bug Something isn't working label Jul 9, 2024
@ocelotl ocelotl self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant