Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR instructions miss a small step #3969

Closed
zhihali opened this issue Jun 13, 2024 · 1 comment
Closed

PR instructions miss a small step #3969

zhihali opened this issue Jun 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@zhihali
Copy link
Contributor

zhihali commented Jun 13, 2024

Describe your environment

No response

What happened?

Here is the part of contribution.md

Pull Requests
How to Send Pull Requests
Everyone is welcome to contribute code to opentelemetry-python via GitHub pull requests (PRs).

To create a new PR, fork the project in GitHub and clone the upstream repo:

$ git clone https://github.com/open-telemetry/opentelemetry-python.git
Add your fork as an origin:

$ git remote add fork https://github.com/YOUR_GITHUB_USERNAME/opentelemetry-python.git

before this step:
$ git remote add fork https://github.com/YOUR_GITHUB_USERNAME/opentelemetry-python.git

we should add a new step, jump in to the folder you just create, bcz it will not jump to it automatically

Steps to Reproduce

no need

Expected Result

detailed steps

Actual Result

not detail enough

Additional context

No response

Would you like to implement a fix?

Yes

@zhihali zhihali added the bug Something isn't working label Jun 13, 2024
@pmcollins
Copy link
Member

Thank you for the fix @Charlie-lizhihan. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants