Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenAI Semantic Convention #3868

Closed
gyliu513 opened this issue Apr 22, 2024 · 5 comments · Fixed by #3964
Closed

Add GenAI Semantic Convention #3868

gyliu513 opened this issue Apr 22, 2024 · 5 comments · Fixed by #3964

Comments

@gyliu513
Copy link
Member

Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.

Is your feature request related to a problem?
Gen AI Semantic Convetion has been merged at open-telemetry/semantic-conventions#825 , the semantic convetion sdk needs to be updated to enable Gen AI.

@lmolkova @nirga comments? Thanks

Describe the solution you'd like
What do you want to happen instead? What is the expected behavior?

Describe alternatives you've considered
Which alternative solutions or features have you considered?

Additional context
Add any other context about the feature request here.

@gyliu513
Copy link
Member Author

Related to traceloop/openllmetry#880

@nirga
Copy link

nirga commented Apr 22, 2024

@lmolkova this should get generated automatically, right?

@gyliu513
Copy link
Member Author

Good to know, @lmolkova @nirga do you know if there are any documentation that I can refer to check the how this will be generated automatically? Thanks

@lmolkova
Copy link
Contributor

yes, once otel semconv is released, then someone can come to this repo and update semconv to the latest version.

There is a script that generates attribute names and values here - https://github.com/open-telemetry/opentelemetry-python/blob/main/scripts/semconv/generate.sh, but it's about to change quite a bit in #3586.

There are docs here https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/README.md#code-generator.

To be fair, I don't think that auto-generation of 10-20 attributes we've introduced in the GenAI semconv so far is worth a hustle - you can always define them as a constants in instrumentation libraries and once semconv are stabilized, switch over to the semantic-conventions library (or not).

@nirga
Copy link

nirga commented Apr 23, 2024

In that case we can just update the ai-semconv in our repo @gyliu513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants