Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(opentracing-shim): Add Close operation #3129

Closed
srikanthccv opened this issue Jan 14, 2023 · 2 comments
Closed

(opentracing-shim): Add Close operation #3129

srikanthccv opened this issue Jan 14, 2023 · 2 comments
Assignees

Comments

@srikanthccv
Copy link
Member

If this operation is implemented for a specific OpenTracing language,
it MUST close the underlying TracerProvider if it implements a "closeable" interface or method;
otherwise it MUST be defined as a no-op operation.

The Shim layer MUST protect against errors or exceptions raised while closing the
underlying TracerProvider.

Spec: open-telemetry/opentelemetry-specification#3048

@nstawski
Copy link
Contributor

I would like to take this issue.

@srikanthccv
Copy link
Member Author

@nstawski mentioned there is no Close operation in OpenTracing Python Tracer. We don't need to add it in the shim package. Thanks @nstawski.

@srikanthccv srikanthccv closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants