Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE is used in MetricReader base class #2792

Closed
ocelotl opened this issue Jun 30, 2022 · 0 comments · Fixed by #2843
Closed

OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE is used in MetricReader base class #2792

ocelotl opened this issue Jun 30, 2022 · 0 comments · Fixed by #2843
Assignees
@lzchen
Labels
metrics sdk Affects the SDK package.

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jun 30, 2022 •
edited by aabmass
Loading

This OTLP specific environment variable is being checked in the base MetricReader class. This seems like a bug, because the base class is respecting that envvar even if the exporter is not OTLP.

opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py

Line 184 in 078eb65

OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE,

@ocelotl ocelotl mentioned this issue Jun 30, 2022
Merged
@aabmass aabmass changed the title Looks like if someone sets the OTLP environemnt variable to DELTA, it will cause this to be configured for deltas: OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE is used in MetricReader base class Jun 30, 2022
@aabmass aabmass added sdk Affects the SDK package. metrics labels Jun 30, 2022
@lzchen lzchen self-assigned this Jul 21, 2022
@lzchen lzchen moved this to Todo in Python Metrics Stable Jul 21, 2022
@lzchen lzchen mentioned this issue Jul 26, 2022
Merged
@ocelotl ocelotl moved this from Todo to In Progress in Python Metrics Stable Jul 28, 2022
@ocelotl ocelotl moved this from In Progress to Done in Python Metrics Stable Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
metrics sdk Affects the SDK package.
Projects
No open projects
Python Metrics Stable
Status: Done
Milestone
No milestone
3 participants
@aabmass @ocelotl @lzchen