Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics] Consume measurements of remaining async instruments when one fails #2545

Closed
overmeulen opened this issue Mar 23, 2022 · 1 comment · Fixed by #2614
Closed

[Metrics] Consume measurements of remaining async instruments when one fails #2545

overmeulen opened this issue Mar 23, 2022 · 1 comment · Fixed by #2614
Assignees
Labels
1.10.0rc1 release candidate 1 for metrics GA bug Something isn't working feature-request metrics sdk Affects the SDK package.

Comments

@overmeulen
Copy link
Contributor

Describe the solution you'd like
Today when the callback of one async instrument fails the whole iteration fails and the remaining measurements are skipped.
I'd like for the exception to be caught and logged and for the remaining async instruments to be processed normally

Describe alternatives you've considered
Today I'm handling this on my side by decorating my callback to catch and log any exceptions

Additional context
https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/_metrics/measurement_consumer.py#L74

@ocelotl ocelotl added metrics sdk Affects the SDK package. labels Mar 23, 2022
@aabmass
Copy link
Member

aabmass commented Mar 23, 2022

@overmeulen thank you for trying out metrics, this this is indeed a bug.

@ocelotl ocelotl added bug Something isn't working 1.10.0rc1 release candidate 1 for metrics GA labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.10.0rc1 release candidate 1 for metrics GA bug Something isn't working feature-request metrics sdk Affects the SDK package.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants