Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate operations for instruments #2393

Closed
lzchen opened this issue Jan 20, 2022 · 0 comments · Fixed by #2394
Closed

Validate operations for instruments #2393

lzchen opened this issue Jan 20, 2022 · 0 comments · Fixed by #2394
Assignees
@lzchen
Labels
1.10.0rc1 release candidate 1 for metrics GA enhancement New feature or request metrics sdk Affects the SDK package.

Comments

@lzchen
Copy link
Contributor

lzchen commented Jan 20, 2022 •
edited
Loading

Certain instruments have limitations for what can be passed in for their add/record operations. We should at least log a message and prevent users from doing so for these cases.
@lzchen lzchen added enhancement New feature or request sdk Affects the SDK package. metrics 1.10.0rc1 release candidate 1 for metrics GA labels Jan 20, 2022
@lzchen lzchen self-assigned this Jan 20, 2022
@lzchen lzchen mentioned this issue Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
1.10.0rc1 release candidate 1 for metrics GA enhancement New feature or request metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate add/record operations for instruments lzchen/opentelemetry-python
1 participant
@lzchen