Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logging signal doesn't have a default log emitter provider #2357

Closed
codeboten opened this issue Jan 8, 2022 · 4 comments
Closed

The logging signal doesn't have a default log emitter provider #2357

codeboten opened this issue Jan 8, 2022 · 4 comments
Labels
api Affects the API package. logging sdk Affects the SDK package.

Comments

@codeboten
Copy link
Contributor

As identified during the work for #2354, the log emitter provider doesn't have a default or noop implementation.

@codeboten codeboten changed the title The logging signal doesn't have a default log emitter provider. Should this be raised as an issue? The logging signal doesn't have a default log emitter provider Jan 8, 2022
@srikanthccv
Copy link
Member

Does this apply to the logging? Unlike metrics and traces, logging doesn't have an API. In case tracing/metrics user adds new instrumentation code and may need the no-op. With logging SDK, we are only taking the whatever the logs emitted and exporting them to backend. If they don't want that then they can simply remove the OTLPHandler.

@lzchen
Copy link
Contributor

lzchen commented Mar 14, 2022

@codeboten
Wdyt?

@lzchen lzchen added the logging label Mar 14, 2022
@ocelotl
Copy link
Contributor

ocelotl commented Mar 17, 2022

In my opinion, the NoOpX classes are the API implementation of the API, if there is no API, then there should not be any need for NoOpLogEmitter.

@srikanthccv srikanthccv added api Affects the API package. sdk Affects the SDK package. labels Sep 9, 2022
@srikanthccv
Copy link
Member

This is implemented by @lzchen here #3038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the API package. logging sdk Affects the SDK package.
Projects
None yet
Development

No branches or pull requests

4 participants