Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: generate action should work with website docs #2083

Closed
owais opened this issue Aug 30, 2021 · 5 comments
Closed

CI: generate action should work with website docs #2083

owais opened this issue Aug 30, 2021 · 5 comments
Labels
feature-request good first issue Good first issue

Comments

@owais
Copy link
Contributor

owais commented Aug 30, 2021

The generate Github Action checks if any code generation scripts were missed by the contributor and need to be run before the PR can be merged. It should also ensure that website_docs are up to date and the contributor ran ./scripts/generate_website_docs.sh if they made changes to the source material
@rod-dot-codes
Copy link

@owais I've got experience with Github Actions and wouldn't mind picking this up for #hacktoberfest

@owais
Copy link
Contributor Author

owais commented Oct 2, 2021

Thanks @rod-dot-codes. I've assigned it to you.

@chalin
Copy link
Contributor

chalin commented Mar 3, 2022

Given that website_docs has been removed (#2452), maybe this issue can be closed?

@lzchen
Copy link
Contributor

lzchen commented Mar 10, 2022

@owais
I believe this can be closed.

@rod-dot-codes rod-dot-codes removed their assignment Mar 11, 2022
@ocelotl
Copy link
Contributor

ocelotl commented Mar 17, 2022

@owais I believe this can be closed.

I agree. Closing this issue, @owais please feel free to reopen if you consider so 🙂

@ocelotl ocelotl closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request good first issue Good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@owais @rod-dot-codes @chalin @ocelotl @lzchen