Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema_url to TracerProvider.get_tracer #1971

Closed
NathanielRN opened this issue Jul 19, 2021 · 2 comments
Closed

Add schema_url to TracerProvider.get_tracer #1971

NathanielRN opened this issue Jul 19, 2021 · 2 comments
Assignees
Labels
api Affects the API package. feature-request good first issue Good first issue

Comments

@NathanielRN
Copy link
Contributor

Follow up to #1862

The spec in 1.4.0 added an optional parameter schema_url to the TracerProvider.get_tracer method which we still need to implement:

class TracerProvider(ABC):
@abstractmethod
def get_tracer(
self,
instrumenting_module_name: str,
instrumenting_library_version: str = "",
) -> "Tracer":

We would need to update the API package + the SDK package.

@lzchen lzchen added api Affects the API package. good first issue Good first issue labels Jul 23, 2021
@JamesJHPark
Copy link
Contributor

@codeboten - please assign me this issue

@srikanthccv
Copy link
Member

Fixed in #2154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the API package. feature-request good first issue Good first issue
Projects
None yet
Development

No branches or pull requests

4 participants