Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use w3c format for reading headers via environment variables #1949

Closed
srikanthccv opened this issue Jul 13, 2021 · 1 comment · Fixed by #2103
Closed

Use w3c format for reading headers via environment variables #1949

srikanthccv opened this issue Jul 13, 2021 · 1 comment · Fixed by #2103
Assignees
@srikanthccv
Labels
enhancement New feature or request good first issue Good first issue triaged

Comments

@srikanthccv
Copy link
Member

No need to necessarily change this here, but i think we're repeating the pattern of splitting variables by , and = in a few places, might be nice to pull that code into a utility.

Originally posted by @codeboten in #1868 (comment)

Also, we need to document the escape sequence and link to w3c correlation key-value pairs regex.
@srikanthccv srikanthccv added triaged enhancement New feature or request good first issue Good first issue labels Jul 13, 2021
@srikanthccv srikanthccv mentioned this issue Jul 13, 2021
Merged
@srikanthccv srikanthccv changed the title Refactor and pull out logic used to read and split env vars with , and = Use w3c format for reading headers via environment variables Sep 3, 2021
@srikanthccv srikanthccv self-assigned this Sep 3, 2021
@srikanthccv
Copy link
Member Author

Format spec here https://github.com/w3c/baggage/blob/main/baggage/HTTP_HEADER_FORMAT.md

@srikanthccv srikanthccv mentioned this issue Sep 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanthccv srikanthccv

Labels
enhancement New feature or request good first issue Good first issue triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect headers parsing via environment variables srikanthccv/opentelemetry-python
1 participant
@srikanthccv