-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OTLP_HEADERS with capital case #1851
Comments
Just to clarify, it seems like the comment in the linked issue is suggesting that the entire header key (eg. "Authorization" or "AUTHORIZATION") should be cast to lower case ("authorization")? The otel specifications for OTLP exporters seems to support using all lower-case to match the format of headers in W3C Correlation-Context:
The line in question seems to be here? |
I could fix this, if it's valid! @owais @codeboten |
I don't think the exporter enforces anything here. IIRC, gRPRC expects all metadata (headers) to be lowercase and that's where the error is coming from. |
We could convert all headers to lower case in order to prevent the crash and make it work with gRPC. |
@owais |
Describe your environment
OS:
Ubuntu 20
Python version:
python3.8
Dependencies installed with venv:
Steps to reproduce
Create a OTLP Header with a capital case format:
What is the expected behavior?
Allow to use headers with the first Capital letter
What is the actual behavior?
Additional context
See elastic/apm-server#5169
The text was updated successfully, but these errors were encountered: