We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should_sample
Continuing from here https://cloud-native.slack.com/archives/C01PD4HUVBL/p1618175323112400. Link to specification vs SDK
opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py
Lines 165 to 174 in 489a81e
The args list for should_sample in spec is different from python sdk implementation. This should be addressed.
The text was updated successfully, but these errors were encountered:
I don't think we can remove trace_state, as this will be a breaking change. span_kind should be added though.
trace_state
span_kind
Sorry, something went wrong.
lzchen
Successfully merging a pull request may close this issue.
Continuing from here https://cloud-native.slack.com/archives/C01PD4HUVBL/p1618175323112400.
Link to specification vs SDK
opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py
Lines 165 to 174 in 489a81e
The args list for
should_sample
in spec is different from python sdk implementation. This should be addressed.The text was updated successfully, but these errors were encountered: