Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between spec and sdk implementation of should_sample #1763

Closed
srikanthccv opened this issue Apr 12, 2021 · 1 comment · Fixed by #1764
Closed

Discrepancy between spec and sdk implementation of should_sample #1763

srikanthccv opened this issue Apr 12, 2021 · 1 comment · Fixed by #1764
Assignees

Comments

@srikanthccv
Copy link
Member

Continuing from here https://cloud-native.slack.com/archives/C01PD4HUVBL/p1618175323112400.
Link to specification vs SDK

def should_sample(
self,
parent_context: Optional["Context"],
trace_id: int,
name: str,
attributes: Attributes = None,
links: Sequence["Link"] = None,
trace_state: "TraceState" = None,
) -> "SamplingResult":
pass

The args list for should_sample in spec is different from python sdk implementation. This should be addressed.

@lzchen
Copy link
Contributor

lzchen commented Apr 12, 2021

I don't think we can remove trace_state, as this will be a breaking change. span_kind should be added though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants