-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger/Zipkin/Opencensus exporters should populate service_name from Span Resource #1685
Comments
In a batch will all the spans have the same resource?
Assuming that all spans from a tracer will have same resource we could do something similar to just a thought. |
@dmarar Yes, this makes a lot of sense to me. Span translator should copy resource attributes to process tags (jaeger) and span tags (zipkin). |
I am not sure if you can just take the 0th span and make it's resource as whole batch resource. I haven't closely looked at the span processor code so I don't know yet if it is possible for batch to have spans originating from different resources. Would it be more better if we group them by their resource and make proto.PostSpansRequest/thrift.Batch export for each of them? |
From SIG meeting 03/11/2021 -> We will be restricting users to have a new instance of spanprocessor for each TracerProvider they create, so we can go with taking the 0th span to populate service_name for whole batch. |
Work finished for Zipkin and Jaeger. |
Created a separate issue specifically for the opencensus exporter |
Currently, the three exporters that require service_name collect them all in different ways.
Jaeger -> after this pr, will be populated by global tracer_provider -> resource.
Opencensus -> passes in constructor
Zipkin -> Populated through global tracer_provider -> resource code
Following from @owais 's comment, users can instantiate multiple
TracerProvider
s, which could possibly have differentResource
attached to them, and therefore theservice_name
s could be different.Dot net SDK has a reference to the creating
tracer_provider
in their exporters (which is weird), and Java SDK simply uses the currently exportingSpan
's resource to populateservice_name
. I propose that we do something similar to Java for our exporters.The text was updated successfully, but these errors were encountered: