Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on the versioning for instrumentation packages #1495

Open
ocelotl opened this issue Dec 17, 2020 · 6 comments
Open

Decide on the versioning for instrumentation packages #1495

ocelotl opened this issue Dec 17, 2020 · 6 comments
Labels
discussion Issue or PR that needs/is extended discussion. triaged

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Dec 17, 2020

How will versioning be for instrumentation packages? We should have an answer for that question.

@lzchen please confirm this is the actual topic that you wanted to discuss in this issue 😅

@ocelotl ocelotl added the discussion Issue or PR that needs/is extended discussion. label Dec 17, 2020
@aabmass
Copy link
Member

aabmass commented Dec 17, 2020

Probably related #1159

@lzchen
Copy link
Contributor

lzchen commented Jan 4, 2021

@aabmass
Could you explain a little about how that issue is related?

@lzchen
Copy link
Contributor

lzchen commented Jan 4, 2021

@ocelotl
Trying to job my memory. I believe this issue was created to track the discussion on how we want to version the instrumentation packages. The core packages (api, sdk) will be versioned according to the RATIONALE.md doc, which will follow OT guidelines for versioning and releasing, however the other packages do not need to be versioned together with the core packages.
Another topic of discussion is how we will deal with versioning of the "add-on" packages opentelemetry-distro, opentelemetry-instrumentation, etc.

Currently, we are keeping all the instrumentation package versions in sync with core, and we bump each package version on each release REGARDLESS if there are changes in them or not.

Link to spec

@lzchen lzchen added release:required-for-ga To be resolved before GA release and removed 1.0.0rc1 labels Jan 21, 2021
@codeboten codeboten removed the release:required-for-ga To be resolved before GA release label Jan 21, 2021
@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 3, 2021

@lzchen Is there already a decision made on this topic? I wonder if we can close this issue

@lzchen
Copy link
Contributor

lzchen commented Mar 3, 2021

@codeboten
I don't remember if we came to a concensus.

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@lzchen lzchen added triaged and removed backlog labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issue or PR that needs/is extended discussion. triaged
Projects
None yet
Development

No branches or pull requests

4 participants